Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tags): tag discussion modal filters with exact matches only after first index #3786

Merged
merged 2 commits into from
Apr 10, 2023
Merged

fix(tags): tag discussion modal filters with exact matches only after first index #3786

merged 2 commits into from
Apr 10, 2023

Conversation

rafaucau
Copy link
Contributor

@rafaucau rafaucau commented Apr 10, 2023

Changes proposed in this pull request:
This pull request updates the tag filtering functionality to include partial matches when searching for tags. The previous implementation used substring method to match the tags with the filter string, which only matched tags starting from the beginning of the tag name.

The new implementation uses the includes method to match the filter string with any part of the tag name. This means that users can now search for tags based on partial matches, making it easier to find relevant tags.

Screenshot

Tag list:
image

Before After
Before After

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added this to the 1.8 milestone Apr 10, 2023
@SychO9 SychO9 changed the title Update tag filtering to include partial matches fix: tag discussion modal filters with exact matches only Apr 10, 2023
@SychO9 SychO9 changed the title fix: tag discussion modal filters with exact matches only fix: tag discussion modal filters with exact matches only after first index Apr 10, 2023
@SychO9 SychO9 changed the title fix: tag discussion modal filters with exact matches only after first index fix(tags): tag discussion modal filters with exact matches only after first index Apr 10, 2023
@SychO9 SychO9 merged commit b0aad1a into flarum:main Apr 10, 2023
@rafaucau rafaucau deleted the tag_filtering branch April 10, 2023 20:18
@github-actions github-actions bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants