chore: drop usage of jquery in install and update interfaces
#3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
askvortsov1
requested changes
Apr 16, 2023
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
askvortsov1
reviewed
Apr 16, 2023
| .catch(error => { | ||
| console.error('Error:', error); | ||
| }); | ||
| window.onload = function() { |
There was a problem hiding this comment.
https://stackoverflow.com/a/37401912 might be a better fit, actually
There was a problem hiding this comment.
let me just switch back to jQuery 🤣
There was a problem hiding this comment.
Aaaaaaaaa noooooo!!!!!!!
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
askvortsov1
approved these changes
Apr 16, 2023
|
A bit late here, but I think fetch Promise rejections should be handled too. Otherwise network errors are ignored (they weren't, in the previous jQuery implementation). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3457
Changes proposed in this pull request:
Necessity
Confirmed
composer test).Required changes: