Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unreadable badge icon on certain colors #3810

Merged
merged 1 commit into from
Apr 29, 2023
Merged

fix: unreadable badge icon on certain colors #3810

merged 1 commit into from
Apr 29, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 27, 2023

Fixes #3805

Changes proposed in this pull request:

  • Uses the color contrast utility to fix badge icon color on colored backgrounds.

Screenshot
Screenshot from 2023-04-27 19-42-35
Screenshot from 2023-04-27 19-42-48

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9
fix: unreadable badge icon on certain colors
70617a9 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner April 27, 2023 20:50
@SychO9 SychO9 merged commit 7ebeb9c into main Apr 29, 2023
@SychO9 SychO9 deleted the sm/3805-group-badge-coloring branch April 29, 2023 17:35
@github-actions github-actions bot mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make use of improved color contrast for group badges
2 participants
@SychO9 @davwheat