Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] fix(tags): load correct user tag state and prevent N+1 queries in stateFor #4008

Merged
merged 3 commits into from
Aug 10, 2024

Conversation

rafaucau
Copy link
Contributor

Fixes #4007

Changes proposed in this pull request:

As described in the title. For more details, please refer to issue #4007.

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Backend changes.
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Thanks to @SychO9 for assistance on Discord!

rafaucau and others added 2 commits July 27, 2024 21:08
Co-authored-by: SychO9 <sychocouldy@gmail.com>
Co-authored-by: SychO9 <sychocouldy@gmail.com>
@rafaucau rafaucau requested a review from a team as a code owner July 27, 2024 20:00
@rafaucau rafaucau changed the title [1.x] fix: load correct user tag state and prevent N+1 queries in stateFor [1.x] fix(tags): load correct user tag state and prevent N+1 queries in stateFor Jul 29, 2024
@SychO9 SychO9 merged commit b3366e4 into flarum:1.x Aug 10, 2024
273 checks passed
@rafaucau rafaucau deleted the fix/tag-stage-user branch August 10, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants