Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: overwrite request gas limits and return new values to relay #113

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

prestwich
Copy link
Contributor

@prestwich prestwich commented Sep 6, 2023

📝 Summary

Modifies the v2 endpoint to overwrite gaslimit during simulation, and to return the overwritten values to the relay client

This allows the block-validation logic in the API to adjust the gaslimit set by the block builder in order to achieve specific gas targets specified by the relay api service.

There's some design discussion as to whether this should be a v3. I chose to make the most minimal changeset, as the goal is to have the change be transparent to block builders and proposers. As a result, this API update is not suitable for use by unmodified relay APIs

Disclaimer

I do not have confidence in my modification of the go api to return the new type

📚 References

This is in support of flashbots/mev-boost-relay#519


@prestwich
Copy link
Contributor Author

hard to tell because of the large output, but given the latest commit is non-functional changes it seems likely the CI failure is unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant