Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use tx hash instead of nonce to determine if the tx is a mempool tx #124

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

0xdapper
Copy link

@0xdapper 0xdapper commented Mar 28, 2022

Using nonce to determine is a rather naive way to compare txs. There can be a different tx with same nonce in the mempool. Searchers could want to send same txs with different gas prices(different tx hashes) to the mempool from their EOAs. They could be capturing different opportunities altogether at same nonce too. Nonce cannot be used in place of a tx hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants