Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for refund option on sendPrivateTransaction #48

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

deiay
Copy link

@deiay deiay commented Oct 27, 2023

What

As per flashbots docs, sendPrivateTransaction allows users to specify refund recipients. This exposes a refund parameter on the MevShareClient.sendTransaction and populates the json rpc request accordingly

Other small changes

Docs:

  • Fix links to supported builders

Linting

  • Add eslint lint config that enforces commas on types, inline with how types are linted in this repo. This make format on save work as one would expect
  • Enforce consistent single quote in esconfig

@deiay deiay changed the title Add refund option Add support for refund option on sendPrivateTransaction Oct 27, 2023
@deiay deiay marked this pull request as ready for review October 27, 2023 17:23
@zeroXbrock
Copy link
Member

zeroXbrock commented Jan 11, 2024

thank you for the PR, @deiay! There are now some merge conflicts from some PRs that I just merged -- some overlap with smaller PRs. But the code you posted looks good. If you could please resolve the conflicts, I'll be happy to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants