Dynamic log optional #171
Merged
Dynamic log optional #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanCorDX
requested review from
dvush,
ferranbt,
metachris and
jakubhruby7
as code owners
Benchmark results for
|
| Date (UTC) | 2024-09-10T21:32:17+00:00 |
| Commit | 1d19613385b745b2759ab676d4a4199261629d8b |
| Base SHA | 59e7cd3f389a98d02e2267cbb0457f6c10caa72d |
Significant changes
None
ZanCorDX
force-pushed
the
dynamic-log-optional
branch
2 times, most recently
from
1aada97
to
cdb3da1
Compare
liamaharon
approved these changes
Sep 10, 2024
ZanCorDX
force-pushed
the
dynamic-log-optional
branch
from
cdb3da1
to
1d19613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes on top of #169.
📝 Summary
Allows to disable dynamic logs.
💡 Motivation and Context
In some contexts (eg: TEE) they might be a security leak.
✅ I have completed the following steps:
make lintmake test