suave_structs.go: Marshal bytes to hexstring #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmel
requested review from
ferranbt,
Ruteri,
metachris and
dmarzzz
as code owners
- current: []byte field marshals to base64 string - to be: BuildBlockArgs and DataRecord structs now use hexutil.Big and hexutil.Bytes for uint64 and []byte fields respectively
jinmel
force-pushed
the
suave_struct_hex
branch
from
0fb11f1
to
6a7d39e
Compare
ferranbt
requested changes
Feb 27, 2024
| @@ -243,6 +265,13 @@ type {{.Name}} struct { | |||
| {{range .Fields}}{{title .Name}} {{typ3 .Typ}} | |||
| {{end}} | |||
| } | |||
|
|
|||
| type {{.Name | lower}}Marshaling struct { | |||
There was a problem hiding this comment.
Do you need to do this as part of the code generation?
Could you create another file suave_structs_encoding.go which is not code generated that does the encoding overriding?
| @@ -45,6 +45,11 @@ devtools: | |||
|
|
|||
| suavedevtools: | |||
| go run ./suave/gen/main.go -write | |||
| cd core/types && \ | |||
There was a problem hiding this comment.
Could you use // go:generate to do this? https://github.com/flashbots/suave-execution-geth/blob/feature/e2e-block-building-builderapi/suave/builder/api/api.go#L15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
📚 References