Update scripts following repo submodule removal and rename #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
A newer version of this script lives in the reports repository. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
CROS_WORKON_COMMIT has been replaced by EGIT_COMMIT in ebuilds. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
portage-stable and coreos-overlay used to be submodules of scripts, but this is no longer true in any release channel, so we can drop any code that handles the migration. Submodule-related arguments are still passed to git where they make sense just in case we do start using submodules that don't need special handling. Some of these scripts seem a little overly complex now that they only handle the scripts repo, but let's not rewrite them now. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Compatibility symlinks have been added to the scripts repo, but they are not needed by these scripts. `git show` cannot follow them, so we need to explicit check both the new and old locations. coreos-overlay-diff.py has been renamed to flatcar-overlay-diff.py and now accepts --flatcar-overlay, but --coreos-overlay has been kept as an alias. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
2 tasks
chewi
changed the title
I was about to ask about testing - you should be able to test this your own fork. After that you can paste the commands you executed and the output confirming things work as expected. |
|
Looking good. |
sayanchowdhury
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scripts following repo submodule removal and rename
portage-stable and coreos-overlay used to be submodules of scripts, but this is no longer true in any release channel, so we can drop any code that handles the migration.
These package repositories will also be moved and renamed to gentoo-subset and flatcar-overlay respectively, so these scripts need adjusting accordingly. The changes are backwards-compatible, so we don't need to wait for the move/rename to actually happen first.
A couple of other scripts are obsolete and can simply be removed.
How to use
Use the scripts as usual!
Testing done
I have tested coreos-overlay-diff.py (which has another issue, see #159) and show-changes. The other changes are either trivial or hard to test, like tag-release.