Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miao0miao/flatcar jitsi automation #4

Merged
merged 14 commits into from
Aug 5, 2024
Merged

Miao0miao/flatcar jitsi automation #4

merged 14 commits into from
Aug 5, 2024

Conversation

miao0miao
Copy link
Contributor

Making jitsi provisioning automated for Flatcar

  • Making jitsi deployment is fully configurable before provisioning, provisioning is automated for Flatcar. OS and Sysext update concepts are integrated and allow for customisation (during maintenance windows).
  • Also provisioning can be tested in a local qemu VM.

@tormath1
Copy link
Contributor

@miao0miao thanks for opening the PR! We usually set the assignees to the person who's working on the PR (you) and set the reviewers to flatcar/flatcar-maintainers (to avoid selecting all the Flatcar maintainers one by one)

@t-lo t-lo requested a review from a team July 23, 2024 10:55
@t-lo
Copy link
Member

t-lo commented Jul 27, 2024

@miao0miao @tormath1 any updates on this?
The PR should be really straightforward to test, all you need is access to a DNS hoster for a Jitsi hostname. If it's not then this PR needs more work 😀
Maybe we could even convince Danielle to demo this at the August office hours?

tormath1
tormath1 reviewed Jul 30, 2024
View reviewed changes
config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
generate_config.sh Outdated Show resolved Hide resolved
generate_config.sh Outdated Show resolved Hide resolved
jitsi-install.service Show resolved Hide resolved
t-lo and others added 12 commits August 4, 2024 12:41
@t-lo
flatcar-jitsi.sh: bump to stable-7882
8dad457 
This change bumps the Jitsi docker image release to 7882, which is
latest and greatest at the time of writing. It also adds
JITSI_IMAGE_VERSION to the .env file to ease upgrading once deployed.

Signed-off-by: Thilo Fromm <thilo@kinvolk.io>
@t-lo
flatcar-jitsi.sh: use git apply, docker compose
198374f
@t-lo
flatcar.env: restructure, add HTTP and HTTPS ports
d3e2b03 
Jitsi defaults to HTTP on port 8000, HTTPS on port 8443. We expose these ports directly as there is no need for an external proxy.

This change also restructures the env file a bit to aid readability.
@miao0miao @t-lo
flatcar.env change for local testing
f4eca16
@t-lo
flatcar-jitsi.sh: Added host IP, wait for DNS options
67d6c3d
@miao0miao @t-lo
config.yaml: add Flatcar butane config
e80ae7c
@miao0miao @t-lo
miao0miao/adding files for the Flatcar installer
f6b6975
@t-lo
fetch-jitsi-files.sh: fetch install files from jitsi-docker
b465937 
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
@t-lo
generate_config.sh: Local config generation script
bacb7f4
@t-lo
Fixed some issues with the new self-contained set-up and added docs
b6c6a87 
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
@t-lo
EADME.md: list required ports
9addac7
@t-lo @tormath1
Address review feedback, reduce ignition cfg size
d731ea8 
Co-authored-by: Mathieu Tortuyaux <mathieu.tortuyaux@gmail.com>
@t-lo
Copy link
Member

t-lo commented Aug 4, 2024 •
edited
Loading

Addressed review feedback:

  • generate_config.sh now allows specifying target architecture and now generates config.yaml from config.yaml.tmpl.
  • merged minor improvements and fixes proposed in review
  • updated README
  • squashed some commits and rebased, resolved conflicts with main branch

Also pointed 'flatcar-banner.png' download source in config.yaml.tmpl to main branch instead of PR branch as it is expected that we delete the PR branch after merge.

@t-lo t-lo requested a review from tormath1 August 4, 2024 11:57
@miao0miao miao0miao merged commit 1f66cee into main Aug 5, 2024
@tormath1 tormath1 deleted the miao0miao/flatcar_port branch August 5, 2024 10:48
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-lo t-lo t-lo left review comments

@tormath1 tormath1 tormath1 approved these changes

Assignees

@t-lo t-lo

@miao0miao miao0miao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miao0miao @tormath1 @t-lo @chewi @gabriel-samfira @ader1990