Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change More Dates in UI to be Localised #801

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

justdan96
Copy link
Contributor

Change More Dates in UI to Use Local Format

As discussed on Matrix, I found some dates were not being localised so I have made changes so that more dates are localised correctly.

How to use

Make the repo and then run Nebraska locally, check that dates are in the local format.

Testing done

Opened UI and checked dates are in UK format, since my laptop is in UK localisation.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, the tests are now passing except for the code coverage:

Jest: "global" coverage threshold for branches (26.29%) not met: 26.19%
Jest: "global" coverage threshold for lines (35.3%) not met: 35.26%

Since you did not modify the logic, nor added new stuffs, I think we can just update the default (and arbitrary) values:

diff --git a/frontend/package.json b/frontend/package.json
index 1ca0a3f..3eb618f 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -144,9 +144,9 @@
     "coverageThreshold": {
       "global": {
         "statements": 34.95,
-        "branches": 26.29,
+        "branches": 26.19,
         "functions": 30.35,
-        "lines": 35.3
+        "lines": 35.26
       }
     },
     "coverageReporters": [

You can also squash all your commits into one. Thanks!

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix and for your patience :) This will go in staging and it should be available in the next Nebraska release.

@tormath1 tormath1 merged commit 2054d11 into flatcar:main Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants