Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LICENSE: add Apache 2.0 license #1

Merged
merged 1 commit into from
Jun 23, 2023
Merged

LICENSE: add Apache 2.0 license #1

merged 1 commit into from
Jun 23, 2023

Conversation

t-lo
Copy link
Member

@t-lo t-lo commented Jun 23, 2023

No description provided.

@t-lo
LICENSE: add Apache 2.0 license
76b6e60 
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
@t-lo t-lo requested review from krnowak and miao0miao June 23, 2023 10:11
krnowak
krnowak reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah, that stuff. I was supposed to do it, but fell through the cracks. Sorry about it.

But in order to do it properly - should the three scripts in the repo have the boilerplate notice as explained in the appendix at the bottom of the license?

miao0miao
miao0miao approved these changes Jun 23, 2023
View reviewed changes
Copy link

@miao0miao miao0miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM license-wise, donno regarding @krnowak 's comment

@t-lo
Copy link
Member Author

t-lo commented Jun 23, 2023

Bah, that stuff. I was supposed to do it, but fell through the cracks. Sorry about it.

But in order to do it properly - should the three scripts in the repo have the boilerplate notice as explained in the appendix at the bottom of the license?

I think for a basic scan having the license in the repo will do, but feel free to add a notice in the script!
We usually use (c) The Flatcar Maintainers or something.

@t-lo t-lo merged commit 300f28b into master Jun 23, 2023
@t-lo t-lo deleted the t-lo/add-license branch June 23, 2023 12:49
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krnowak krnowak krnowak left review comments

@miao0miao miao0miao miao0miao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-lo @krnowak @miao0miao