Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-lang/nasm: sync with the upstream #2110

Merged
merged 4 commits into from
Jul 9, 2024
Merged

dev-lang/nasm: sync with the upstream #2110

merged 4 commits into from
Jul 9, 2024

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Jul 8, 2024 •
edited
Loading

This was not in the portage-stable-packages-list and this closes a few CVEs: flatcar/Flatcar#1100

Closes: flatcar/Flatcar#1100

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.
  • CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1536/cldsv/ (with SDK build)

Testing done

$ sudo podman load < flatcar-sdk-amd64-9999.9.9-tormath1-nasm.tar.zst
$ ./run_sdk_container -C ghcr.io/flatcar/flatcar-sdk-amd64:9999.9.9-tormath1-nasm  -a amd64 -t
sdk@flatcar-sdk-amd64-4020_0_0-nightly-20240703-2100_os-main-4020_0 ~/trunk/src/scripts $ nasm --version
NASM version 2.16.01 compiled on Jul  8 2024

@tormath1
dev-lang/nasm: sync with upstream
db92389 
Commit-Ref: gentoo/gentoo@ea8b0bb

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
changelog: add entries
9395757 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
.github: add dev-lang/nasm to portage-stable-packages-list
3d5cc80 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 self-assigned this Jul 8, 2024
@tormath1
base/keywords: remove nasm 2.15
7c1d0c3 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 added the main label Jul 8, 2024
@tormath1 tormath1 marked this pull request as ready for review July 8, 2024 17:07
@tormath1 tormath1 requested a review from a team July 8, 2024 17:07
ader1990
ader1990 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ader1990 ader1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tormath1 tormath1 merged commit 7ac20b6 into main Jul 9, 2024
1 check failed
@tormath1 tormath1 deleted the tormath1/nasm branch July 9, 2024 07:21
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ader1990 ader1990 ader1990 approved these changes

Assignees

@tormath1 tormath1

Labels
main
Projects
Flatcar tactical, release planning, and roadmap
Status: Implemented
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update: nasm
2 participants
@tormath1 @ader1990