Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-base/coreos-init: Work around bash regression and handle dd error #948

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

pothos
Copy link
Member

@pothos pothos commented Jun 26, 2023

This pulls in
flatcar/init#97
and
flatcar/init#99
to work around a bash regression and add handling for disk write errors.

How to use

Backport to Alpha and Beta, maybe also Stable?
Needs to be done through init backport branches for Beta/Stable.

Testing done

So far only manual testing. Jenkins test started with Equinix Metal.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Closes: flatcar/Flatcar#1059

This pulls in
flatcar/init#97
and
flatcar/init#99
to work around a bash regression and add handling for disk write errors.
@tormath1
Copy link
Contributor

The main issue occurs only for Alpha / Beta - I'm fine with backporting only on these branches for the moment.

@github-actions
Copy link

github-actions bot commented Jun 26, 2023

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is OK, I locally tested again - it's good to go!

@pothos pothos merged commit bd242ea into main Jun 27, 2023
1 check failed
@pothos pothos deleted the kai/install-fix branch June 27, 2023 09:39
pothos added a commit that referenced this pull request Jun 27, 2023
coreos-base/coreos-init: Work around bash regression and handle dd error
@pothos
Copy link
Member Author

pothos commented Jun 27, 2023

Backported to Alpha and Beta (using flatcar-3602-backport as init branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install script not working correctly on the latest versions
2 participants