build_sysext: bugfixes, QoL changes, help updated #983
Conversation
This change improves build_sysext by sourcing a missing lib dependency, adding a number of comfort / quality-of-life options, and updating the output of '--help' accordingly. The OEM sysext finction in build_library/vm_image_util.sh is also updated to use new command line format. 1. Include missing dependency toolchain_util.sh to fix an error in board_options.sh (get_board_arch undefined). 2. Use positional parameters for mandatory arguments. build_dir and sysext_name are mandatory and are now positional arguments instead of options. binary_package is the third positional argument but can be omitted if --metapkgs was specified. 3. --squashfs_base is now guessed better and will use the most recent build by default. 4. A new boolean flag --ignore_version_mismatch for the more daring developer was added. The flag will cause the script to continue if a version mismatch between SDK board packages and squashfs base is detected. 5. Error messages were improved for when mandatory parameters were not provided. 6. The '--help' message was improved and adjusted to the new parameters. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
build_sysext
Outdated
| @@ -14,42 +14,55 @@ SCRIPT_ROOT=$(dirname "$(readlink -f "$0")") | |||
| assert_inside_chroot | |||
| assert_root_user | |||
|
|
|||
| default_squashfs_base="$(readlink -f "${SCRIPT_ROOT}/../build/images/amd64-usr/latest/${FLATCAR_PRODUCTION_IMAGE_SYSEXT_BASE}")" | |||
There was a problem hiding this comment.
That's what I get from copy-pasting my command lines, meh. Will fix.
|
can you also add |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/5486621593 |
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
|
Fixed hard-coded architecture, added |
There was a problem hiding this comment.
Cool. Nice improvements, thanks!
The situation with meta packages being passed in a different way than binary packages (a flag with comma-separated list as its value vs. a list of positional parameters) is a bit iffy, but I don't really have anything better to suggest right now.
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
|
@krnowak @jepio One more round please: This allows a user, after a build, to plainly run ./build_sysext python dev-lang/pythonto build a python sysext for the OS image that was just built. |
This change improves
build_sysextby sourcing a missing lib dependency, adding a number of comfort / quality-of-life options, and updating the output of--helpaccordingly.The OEM sysext finction in
build_library/vm_image_util.shis also updated to use new command line format.toolchain_util.shto fix an error inboard_options.shwhen--boardwas not specified (get_board_archundefined).sysext_nameandbinary_packageare positional arguments now; the latter can be omitted if--metapkgswas specified.--squashfs_baseis now guessed better and will use the most recent build by default.--image_builddiris now guessed and defaults to asysextsub-directory in the directory the squashfs base resides in.--ignore_version_mismatchfor the more daring developer was added. The flag will cause the script to continue if a version mismatch between SDK board packages and squashfs base is detected.--helpmessage was improved and adjusted to the new parameters.Tested with a custom sysext build and with a
image_to_vm.shqemu build (for testing the generic OEM sysext build).