Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump dockerfile base image to python 3.10 #280

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

bvolkmer
Copy link

See #275

@bvolkmer
Copy link
Author

I tested it on my personal instance, which works with eBay Kleinanzeigen and wg-gesucht.de. Immoscout24 test is not possible in docker due to #272.

Copy link

@codders codders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you!

@bvolkmer bvolkmer temporarily deployed to test December 20, 2022 14:07 — with GitHub Actions Inactive
@bvolkmer bvolkmer temporarily deployed to test December 20, 2022 14:07 — with GitHub Actions Inactive
@bvolkmer bvolkmer temporarily deployed to test December 20, 2022 14:07 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #280 (56e9073) into main (4b20fe2) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   64.42%   64.26%   -0.16%     
==========================================
  Files          36       36              
  Lines        1875     1875              
  Branches      251      251              
==========================================
- Hits         1208     1205       -3     
- Misses        603      604       +1     
- Partials       64       66       +2     
Impacted Files Coverage Δ
flathunter/crawl_immowelt.py 67.69% <0.00%> (-3.08%) ⬇️
flathunter/abstract_crawler.py 38.46% <0.00%> (-1.40%) ⬇️
flathunter/crawl_immobiliare.py 94.87% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codders codders merged commit f8309ba into flathunters:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants