Skip to content

Commit

Permalink
- updated documentation
Browse files Browse the repository at this point in the history
- removed .idea
- updated TODO in files
  • Loading branch information
flaviu-chelaru committed Apr 28, 2017
1 parent 4eea88d commit 57de208
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 69 deletions.
68 changes: 2 additions & 66 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,72 +1,8 @@
# Created by https://www.gitignore.io/api/phpstorm

### PhpStorm ###
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and Webstorm
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839

# User-specific stuff:
.idea/**/workspace.xml
.idea/**/tasks.xml
.idea/dictionaries

# Sensitive or high-churn files:
.idea/**/dataSources/
.idea/**/dataSources.ids
.idea/**/dataSources.xml
.idea/**/dataSources.local.xml
.idea/**/sqlDataSources.xml
.idea/**/dynamic.xml
.idea/**/uiDesigner.xml

# Gradle:
.idea/**/gradle.xml
.idea/**/libraries

# CMake
cmake-build-debug/

# Mongo Explorer plugin:
.idea/**/mongoSettings.xml

## File-based project format:
*.iws

## Plugin-specific files:

# IntelliJ
/out/

# mpeltonen/sbt-idea plugin
.idea_modules/

# JIRA plugin
atlassian-ide-plugin.xml

# Cursive Clojure plugin
.idea/replstate.xml

# Crashlytics plugin (for Android Studio and IntelliJ)
com_crashlytics_export_strings.xml
crashlytics.properties
crashlytics-build.properties
fabric.properties

### PhpStorm Patch ###
# Comment Reason: https://github.com/joeblau/gitignore.io/issues/186#issuecomment-215987721

# *.iml
# modules.xml
# .idea/misc.xml
# *.ipr

# Sonarlint plugin
.idea/sonarlint

# End of https://www.gitignore.io/api/phpstorm

.idea
composer.phar
/vendor/
index.php
# Commit your application's lock file http://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file
# You may choose to ignore a library lock file http://getcomposer.org/doc/02-libraries.md#lock-file
# composer.lock
.idea/inspectionProfiles/
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
# phantomjs-cloud
# PhantomJS Cloud

A library to interact with the Phantom JS Cloud

The library will generate the JSON Object. This object can be later sent as a HTTP Request with Guzzle or other HTTP Client for PHP.
3 changes: 2 additions & 1 deletion src/RequestSettings.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class RequestSettings
* Type declaration
* password: string
* userName: string
* TODO Make an object to represent the data
*
* @var array
*/
Expand Down Expand Up @@ -53,7 +54,7 @@ class RequestSettings
* They will be sent to the server for every request issued (the page and resources).
* !IMPORTANT! Unicode is not supported (ASCII only)
*
* @var array[]
* @var array
*/
public $customHeaders;

Expand Down
2 changes: 1 addition & 1 deletion src/UrlSettings.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class UrlSettings
public $encoding = 'utf8';

/**
* custom headers for the taret page. if you want to set headers for every sub-resource requested,
* custom headers for the target page. if you want to set headers for every sub-resource requested,
* use the pageRequest.requestSettings.customHeaders parameter instead.
*
* @var array
Expand Down
2 changes: 2 additions & 0 deletions src/UserResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ class UserResponse
{
/**
* the rendered output of the last pageRequest
* TODO Make an object to represent the data
*
* @var array
*/
public $content;

/**
* metadata about the transaction
* TODO Make an object to represent the data
*
* @var array
*/
Expand Down

0 comments on commit 57de208

Please sign in to comment.