Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect use of FCL_BUILD_TYPE_DEBUG #153

Merged
merged 1 commit into from
Aug 8, 2016
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 8, 2016

The build type check with FCL_BUILD_TYPE_DEBUG and FCL_BUILD_TYPE_RELEASE should be done using their values instead of whether they are defined or not since they are always defined.

@sherm1
Copy link
Member

sherm1 commented Aug 8, 2016

Change looks good.

Question: is it useful to have these macros in addition to the language-standard NDEBUG macro?

@jslee02
Copy link
Member Author

jslee02 commented Aug 8, 2016

Question: is it useful to have these macros in addition to the language-standard NDEBUG macro?

When I added those macros, I considered the case FCL would like to have more build types (e.g., BUILD_TYPE_RELWITHDEBINFO and BUILD_TYPE_MINSIZEREL) with different behaviors, but haven't found any use case so far. I'm not against removing them.

@sherm1
Copy link
Member

sherm1 commented Aug 8, 2016

Could be a topic for a different PR.

@jslee02 jslee02 merged commit 4eaab6e into fcl-0.4 Aug 8, 2016
@jslee02 jslee02 deleted the fix_release_mode_tests branch August 11, 2016 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants