Explicitly require VS2015 or greater #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherm1
approved these changes
Nov 10, 2016
| if(MSVC) | ||
| if(MSVC_VERSION VERSION_LESS 1900) | ||
| message(FATAL_ERROR "${PROJECT_NAME} requires Visual Studio 2015 or greater.") | ||
| endif() | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHsc /MP /W1 /bigobj") | ||
| if(FCL_TREAT_WARNINGS_AS_ERRORS) | ||
| add_definitions(/WX) | ||
| endif(FCL_TREAT_WARNINGS_AS_ERRORS) |
There was a problem hiding this comment.
Consider endif() for consistency.
There was a problem hiding this comment.
Actually, I don't know which one is the convention here. Some endif() contain the parameter while some don't. Do we want to use endif() for other places as well?
Edit: I personally prefer endif() because sometimes it's not clear which parameter should be used. For example:
if(SOME_CONDITION)
...
elseif(SOME_OTHER_CONDITION)
...
endif(SOME_CONDITION? or SOME_OTHER_CONDITIONS?)There was a problem hiding this comment.
I agree! endif() is always better, IMO. That is very clear when the original condition is some complicated expression!
|
I removed conditions from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #184