Fix more compiler warnings #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslee02
approved these changes
Jan 27, 2017
CMakeModules/CompilerSettings.cmake
Outdated
| @@ -1,14 +1,14 @@ | |||
| # GCC | |||
| if(CMAKE_COMPILER_IS_GNUCXX) | |||
| add_definitions(-std=c++11 -W -Wall -g -Wextra -Wpedantic -Wno-missing-field-initializers -Wno-unused-parameter) | |||
| add_definitions(-std=c++11 -W -Wall -g -Wextra -Wpedantic -Wno-unused-parameter) | |||
There was a problem hiding this comment.
I believe we could remove -Wno-unused-parameter as well. One case could be a problem I can think of is using variables that are only used in assertions. For that case, we could use a macro to suppress the warning as we did in DART.
There was a problem hiding this comment.
Almost, I have another PR for that. Touches something like 36 files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @jslee02.