Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build when libccd package config not found. #94

Merged
merged 1 commit into from
Mar 22, 2016

Conversation

law12019
Copy link
Contributor

Link to ccd library by full path per preferred cmake convention. This fixed the build when libccd is not found by pkgconfig.

Link to ccd library by full path per preferred cmake convention.  This fixed the build when libccd is not found by pkgconfig.
@scpeters
Copy link
Contributor

What do you think @j-rivero ?

@j-rivero
Copy link
Contributor

What do you think @j-rivero ?

+1

@mamoll
Copy link
Member

mamoll commented Feb 24, 2016

In a similar vain, but using pkg-config, I use a FindCCD.cmake module in a project that depends on both ccd and fcl:

include(FindPackageHandleStandardArgs)
find_package(PkgConfig)
if(PKGCONFIG_FOUND)
    pkg_check_modules(CCD ccd>=2.0)
    if(CCD_LIBRARIES AND NOT CCD_INCLUDE_DIRS)
        set(CCD_INCLUDE_DIRS "/usr/include")
    endif()
endif()
find_package_handle_standard_args(CCD DEFAULT_MSG CCD_LIBRARIES CCD_INCLUDE_DIRS)

This has the added advantage that you can check for the appropriate libccd version.

@sherm1
Copy link
Member

sherm1 commented Mar 18, 2016

Is this ready to merge?

@mamoll
Copy link
Member

mamoll commented Mar 19, 2016

👍

1 similar comment
@j-rivero
Copy link
Contributor

+1

@jslee02
Copy link
Member

jslee02 commented Mar 21, 2016

I would prefer to use FindCCD.cmake as @mamoll suggested, but this looks good as a stopgap solution. Also, CCD_VERSION variable would be considerable to add to FindCCD.cmake as this.

scpeters added a commit that referenced this pull request Mar 22, 2016
Fix build when libccd package config not found.
@scpeters scpeters merged commit ea10bba into flexible-collision-library:master Mar 22, 2016
@jslee02 jslee02 added this to the FCL 0.5.0 milestone Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants