-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decompose Key Emulate #616
Merged
Programistich
merged 2 commits into
flipperdevices:dev
from
Programistich:refactor/key_emulate_decompose
Jun 15, 2023
Merged
Decompose Key Emulate #616
Programistich
merged 2 commits into
flipperdevices:dev
from
Programistich:refactor/key_emulate_decompose
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionZXY
previously approved these changes
Jun 15, 2023
Comment on lines
60
to
86
val appStartResponse = requestApi.request( | ||
flowOf( | ||
main { | ||
appStartRequest = startRequest { | ||
name = keyType.flipperAppName | ||
args = Constants.RPC_START_REQUEST_ARG | ||
} | ||
}.wrapToRequest(FlipperRequestPriority.FOREGROUND) | ||
) | ||
) | ||
if (appStartResponse.commandStatus == Flipper.CommandStatus.ERROR_APP_SYSTEM_LOCKED) { | ||
error { "Handle already opened app" } | ||
throw AlreadyOpenedAppException() | ||
} | ||
if (appStartResponse.commandStatus != Flipper.CommandStatus.OK) { | ||
error { "Failed start rpc app with error $appStartResponse" } | ||
return false | ||
} | ||
info { "Start waiting for stateAppFlow" } | ||
val appState = withTimeoutOrNull(APP_STARTED_TIMEOUT_MS) { | ||
stateAppFlow.filter { it == Application.AppState.APP_STARTED }.first() | ||
} | ||
if (appState != null) { | ||
info { "Receive that app state started" } | ||
return true | ||
} | ||
info { "Failed wait for app state started" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move it to separate fun
LionZXY
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Step for integrate infared emulate
Changes
Test plan