flipperzero: Enable Miri to start running the tests #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarvisCraft
requested changes
Dec 21, 2023
crates/test/macros/src/lib.rs
Outdated
Comment on lines
144
to
147
| #[cfg(all(test, miri))] | ||
| #[start] | ||
| fn main(argc: isize, argv: *const *const u8) -> isize { | ||
| let ret = __test_runner::main(::core::ptr::null_mut()); |
There was a problem hiding this comment.
Same here, let's add unsafe and the contract for the pointer.
There was a problem hiding this comment.
This cannot be unsafe fn, as it is required to exactly match the expected type of the #[start] function.
str4d
force-pushed
the
basic-miri-support
branch
from
88ad0d7
to
22ee3a3
Compare
str4d
force-pushed
the
basic-miri-support
branch
from
22ee3a3
to
033173a
Compare
|
Force-pushed to address comments. |
str4d
force-pushed
the
basic-miri-support
branch
from
033173a
to
94a1035
Compare
dcoles
approved these changes
Jan 23, 2024
JarvisCraft
approved these changes
Jan 27, 2024
JarvisCraft
previously requested changes
Feb 27, 2024
It doesn't *successfully* run the tests because Miri doesn't yet support
FFI, but these changes enable the following command to actually start:
MIRI_NO_STD=1 cargo miri test --target thumbv7em-none-eabihf
Part of #100.
str4d
force-pushed
the
basic-miri-support
branch
from
94a1035
to
8c7c40e
Compare
str4d
force-pushed
the
basic-miri-support
branch
from
f03d743
to
92f86c3
Compare
|
Pushed a commit to switch to latest nightly for stabilised |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't successfully run the tests because Miri doesn't yet support FFI, but these changes enable the following command to actually start:
Part of #100.