Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run scripts/check as part of scripts/test locally #30

Merged
merged 2 commits into from
Feb 8, 2020

Conversation

florimondmanca
Copy link
Owner

@florimondmanca florimondmanca commented Feb 8, 2020

scripts/test ought to be "check the code as CI does", but we weren't running scripts/check as part of it so far so it wouldn't catch issues that would surface in the Check CI job.

Eg this bit me in #29

@codecov-io
Copy link

codecov-io commented Feb 8, 2020

Codecov Report

Merging #30 into master will increase coverage by 35.63%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #30       +/-   ##
=========================================
+ Coverage   64.36%   100%   +35.63%     
=========================================
  Files           9      9               
  Lines         348    354        +6     
=========================================
+ Hits          224    354      +130     
+ Misses        124      0      -124
Impacted Files Coverage Δ
tests/test_trace_middleware.py 100% <100%> (+46.31%) ⬆️
src/ddtrace_asgi/middleware.py 100% <0%> (+7.69%) ⬆️
tests/applications/starlette.py 100% <0%> (+33.33%) ⬆️
tests/applications/fastapi.py 100% <0%> (+33.33%) ⬆️
tests/applications/raw.py 100% <0%> (+75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f714e...0dfbc0c. Read the comment docs.

@florimondmanca florimondmanca merged commit 9c6bd4c into master Feb 8, 2020
@florimondmanca florimondmanca deleted the test-check branch February 8, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants