aws: utils: fix mem leak in flb_imds_request (#2532)

Signed-off-by: Wesley Pettit <wppttt@amazon.com>
fluent · Sep 6, 2020 · 63b0577 · 63b0577
1 parent d503e11
commit 63b0577
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/aws/flb_aws_util.c b/src/aws/flb_aws_util.c
@@ -444,6 +444,7 @@ int flb_imds_request(struct flb_aws_client *client, char *metadata_path,
 
         if (!ec2_metadata) {
             flb_errno();
+            flb_http_client_destroy(c);
             return -1;
         }
         *metadata = ec2_metadata;
@@ -452,9 +453,9 @@ int flb_imds_request(struct flb_aws_client *client, char *metadata_path,
         flb_http_client_destroy(c);
         return 0;
     }
-    else {
-        flb_debug("[ecs_imds] IMDS metadata response was empty");
-        flb_http_client_destroy(c);
-        return -1;
-    }
+
+    flb_debug("[ecs_imds] IMDS metadata response was empty");
+    flb_http_client_destroy(c);
+    return -1;
+
 }