Engine: implement cb_exit callback for plugins #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaya YAMAMOTO <pandax381@gmail.com>
|
Looks good to me, just a minor suggestion, can we call it "cb_exit" instead of cb_pre_exit ?, the exit point is just one. |
pandax381
changed the title
|
Sure! We call it "cb_exit". |
|
|
edsiper
added a commit
that referenced
this pull request
Sep 2, 2015
Engine: implement cb_exit callback for plugins
|
thanks! |
fujimotos
pushed a commit
to fujimotos/fluent-bit
that referenced
this pull request
Jul 22, 2019
in_dummy: add new documentation about in_dummy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix issue #23
Signed-off-by: Masaya YAMAMOTO <pandax381@gmail.com>