Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_cloudwatch_logs: handle DataAlreadyAcceptedException response #4948

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

PettitWesley
Copy link
Contributor

Signed-off-by: Wesley Pettit wppttt@amazon.com


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Wesley Pettit <wppttt@amazon.com>
@Jell
Copy link

Jell commented Mar 18, 2022

Hitting this issue regularly on our side, and fluent-bit fails to recover after that, this fix would help us a lot

@PettitWesley
Copy link
Contributor Author

@edsiper Can I get a approval & merge on this?

@PettitWesley
Copy link
Contributor Author

@Jell I'd be happy to build you a custom image using the AWS for Fluent Bit build process off of our current stable version or whichever version you are currently using, if that'd help unblock you.

@PettitWesley
Copy link
Contributor Author

Actually @Jell I already built an image with this:

144718711470.dkr.ecr.us-west-2.amazonaws.com/1_8_9_alreadyacceptedissue:latest

This image can be pulled by an AWS account.

@Jell
Copy link

Jell commented Mar 22, 2022

tested your image @PettitWesley it did solve our issues! Would be great to get this merged asap

Copy link

@Jell Jell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch solved the issues we had in production.

@lecaros lecaros added this to the Fluent Bit v1.9.2 milestone Apr 4, 2022
@PettitWesley
Copy link
Contributor Author

@agup006 this is an AWS output fix that I can't merge myself since its my PR

@agup006
Copy link
Member

agup006 commented Apr 4, 2022

I approved based off the successful tests, @PettitWesley are you able to merge now?

@PettitWesley PettitWesley merged commit f78cb44 into fluent:master Apr 4, 2022
@PettitWesley
Copy link
Contributor Author

@agup006 Thanks!!

@geekofalltrades
Copy link

Will these changes be ported to https://github.com/aws/aws-for-fluent-bit?

@PettitWesley
Copy link
Contributor Author

@geekofalltrades Yes, once we start releasing 1.9.x series into AWS distro. We will do this soon. We do not like to consume new series immediately, so 1.9.3 will be the first 1.9 series release we uptake probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants