-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter_kubernetes: Add ability to change kubelet_host #5291
Conversation
Related fluent/fluent-bit#5291 Signed-off-by: Thomas Danielsson <thomas.danielsson@sharespine.com>
Can you rebase as seems to be picking up a fixed error in linting? |
@patrick-stephens Done! |
This is a very valuable addition for secure environments. Can we get the ball rolling on review again? cc codeowners: @edsiper @leonardo-albertovich @fujimotos @koleini |
Allow the user to set kubelet_host when use_kubelet is true. Defaults to '127.0.0.1'. Fixes fluent#5143 Signed-off-by: Thomas Danielsson <thomas.danielsson@sharespine.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know nearly enough about kubernetes to understand the rational of this but the code changes look harmless since the default behavior is retained through the default value in the configuration entry.
I'd say it's good as long as the tests pass.
Related fluent/fluent-bit#5291 Signed-off-by: Thomas Danielsson <thomas.danielsson@sharespine.com>
We also need to specifiy the Kubelet_Host so that fluent-bit knows on which address to contact the kubelet. See: fluent/fluent-bit#5143 fluent/fluent-bit#5291
…#729) * Sets Use_Kubelet=true for kubernetes plugin We also need to specifiy the Kubelet_Host so that fluent-bit knows on which address to contact the kubelet. See: fluent/fluent-bit#5143 fluent/fluent-bit#5291 * Bumps fluent-bit to v1.9.8 * Gives fluentbit rights to "nodes" and "nodes/proxy" This is apparently required of the "Use_Kubelet=true" configuration of the kubernetes filter, allowing it to query the kubelet's /pods endpoint for pod metadata instead of having to contact an api server. * Disables TLS verification of kubelet self-signed cert
Allow the user to set kubelet_host when use_kubelet is true.
Defaults to '127.0.0.1'.
Fixes #5143
Signed-off-by: Thomas Danielsson thomas.danielsson@sharespine.com
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
pipeline: filters: kubernetes: Add kubelet_host fluent-bit-docs#787
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.