opensearch: Aoss master #6612
Merged
opensearch: Aoss master #6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfala
requested review from
PettitWesley,
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
PettitWesley
previously approved these changes
Dec 23, 2022
|
please fix the conflicts on tests/internal/fuzzers/signv4_fuzzer.c |
|
ping |
Signed-off-by: Matthew Fala <falamatt@amazon.com>
matthewfala
force-pushed
the
aoss-master
branch
from
1bfba07
to
2edb926
Compare
|
Rebased, thank you! |
PettitWesley
previously approved these changes
Feb 6, 2023
seaHour
reviewed
Feb 8, 2023
| @@ -1063,6 +1063,11 @@ static struct flb_config_map config_map[] = { | |||
| 0, FLB_FALSE, 0, | |||
| "External ID for the AWS IAM Role specified with `aws_role_arn`" | |||
| }, | |||
| { | |||
| FLB_CONFIG_MAP_STR, "aws_service_name", "es", | |||
There was a problem hiding this comment.
the service name for aws opensearch serverless is "aoss". "es" doesn't work.
There was a problem hiding this comment.
This plugin is meant to be used with serverless and non-serverless. Non-serverless (es) has always been the default. This change allows you to configure something different.
There was a problem hiding this comment.
|
@matthewfala minor change to get this merged, please fix the subjects for these commits:
|
Signed-off-by: Matthew Fala <falamatt@amazon.com>
Signed-off-by: Matthew Fala <falamatt@amazon.com>
matthewfala
force-pushed
the
aoss-master
branch
from
2edb926
to
41bf918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see notes and add comments to : #6448
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.