out_http: don't retry non retryable 4xx status codes #8861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsraelZeromski
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
Fix a problem that http output plugin retries all requests that respond with an 4xx status code excepting 429 status code Signed-off-by: Israel Zeromski <izeromski@salesforce.com>
mrueg
reviewed
May 24, 2024
| flb_plg_warn(ctx->ins, "could not flush records to %s:%i (http_do=%i), " | ||
| "chunk will not be retried", | ||
| ctx->host, ctx->port, ret); | ||
| out_ret = FLB_ERROR; |
There was a problem hiding this comment.
Does that mean logs will be lost when the endpoint is unavailable?
There was a problem hiding this comment.
Yes. if return a code in 4xx range except 429, this means that the are an error in client side in consequence that records will not be retry.
There was a problem hiding this comment.
Fluentd has a setting for retryable response codes: https://docs.fluentd.org/output/http#retryable_response_codes maybe we could add this as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem that http output plugin retries all requests that respond with an 4xx status code excepting 429 status code
Fixes #8860
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.