Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_node_exporter_metrics: systemd: treat states as boolean values. #9136

Closed
wants to merge 1 commit into from

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Jul 27, 2024

Summary

Rewrite the node_exporter_metrics so that the state of systemd units is a boolean instead of incrementing it, ie:

node_systemd_unit_state{...name="keepalived.service",state="active"} 12
node_systemd_unit_state{...name="keepalived.service",state="inactive"} 257

This would instead be:

node_systemd_unit_state{...name="keepalived.service",state="active"} 0
node_systemd_unit_state{...name="keepalived.service",state="inactive"} 1

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Phillip Whelan <phil@calyptia.com>
@edsiper
Copy link
Member

edsiper commented Aug 3, 2024

@pwhelan what's the main difference with the implementation proposed on #9134 ?

@edsiper edsiper added this to the Fluent Bit v3.1.5 milestone Aug 3, 2024
@pwhelan
Copy link
Contributor Author

pwhelan commented Aug 3, 2024

Replaced by #9134.

@pwhelan pwhelan closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants