Fix Operator Precedence for Logical Operations in Stream Processor #9388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unitmatrix
force-pushed
the
fix-sql-conditions
branch
from
4cf3c31
to
a01df75
Compare
Signed-off-by: Aleksandr Cupacenko <apaxuc@gmail.com> revert definition removal Signed-off-by: Aleksandr Cupacenko <apaxuc@gmail.com>
unitmatrix
force-pushed
the
fix-sql-conditions
branch
from
a01df75
to
b50a45a
Compare
unitmatrix
requested review from
edsiper,
leonardo-albertovich and
fujimotos
as code owners
correct precedencer order
unitmatrix
force-pushed
the
fix-sql-conditions
branch
from
50766fe
to
e524174
Compare
|
Thanks @unitmatrix, it would be great if the syntax (https://github.com/fluent/fluent-bit/tree/master/src/stream_processor#sql-statement-syntax) can be updated based on your changes as well. |
|
Hi @koleini, Thank you for your feedback. To ensure that I address your request accurately, I revisited my changes and believe they do not impact the existing SQL statement syntax as outlined in the documentation. Could you please specify which part of the syntax might be affected, or if there are specific updates you have in mind? This will help me make the necessary adjustments to the documentation more effectively. Looking forward to your guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3763
Summary
This pull request addresses the issue where the precedence of logical operators (
AND,OR,NOT) was not defined in the grammar for the stream processor.Changes Made
NOT,AND, andORoperators to the Bison grammar file.NOTnow has the highest precedence.ANDhas middle precedence.ORhas the lowest precedence.Issue Addressed
Fixes GitHub issue: stream_processor: precedence of AND, OR, and NOT not defined in grammar.
Impact
This change ensures that logical operations in conditions are parsed with the correct precedence, aligning with expected logical operation rules.
Testing
Please verify that the logical operations in conditions are handled correctly according to the new precedence rules.
Feel free to reach out if there are any questions or further adjustments needed.