Fix bug with timeline overlay and improve logging (#8318)

flutter · Sep 10, 2024 · fd2988f · fd2988f
1 parent 0a01c48
commit fd2988f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/packages/devtools_app/lib/src/extensions/embedded/_view_web.dart b/packages/devtools_app/lib/src/extensions/embedded/_view_web.dart
@@ -165,8 +165,11 @@ class _ExtensionIFrameController extends DisposableController
     final message = event.toJson();
     assert(
       embeddedExtensionController.extensionIFrame.contentWindow != null,
-      'Something went wrong. The iFrame\'s contentWindow is null after the'
-      ' _iFrameReady future completed.',
+      'Something went wrong. The '
+      '${embeddedExtensionController.extensionConfig.name} extension\'s iFrame '
+      'contentWindow is null after the _iFrameReady future completed. The '
+      'message that was being posted when the error occurred was:\n'
+      '${message.toString()}',
     );
     embeddedExtensionController.extensionIFrame.contentWindow!.postMessage(
       message.jsify(),

diff --git a/...evtools_app/lib/src/screens/performance/panes/timeline_events/perfetto/_perfetto_web.dart b/...evtools_app/lib/src/screens/performance/panes/timeline_events/perfetto/_perfetto_web.dart
@@ -270,8 +270,9 @@ class _PerfettoViewController extends DisposableController
     final iFrameWindow = perfettoController.perfettoIFrame.contentWindow;
     if (iFrameWindow == null) {
       _log.warning(
-        'Something went wrong. The iFrame\'s contentWindow is null after the'
-        ' _perfettoIFrameReady future completed.',
+        'Something went wrong. The Perfetto iFrame\'s contentWindow is null '
+        'after the _perfettoIFrameReady future completed. The message that '
+        'was being posted when the error occurred was:\n${message.toString()}',
       );
       return;
     }

diff --git a/.../devtools_app/lib/src/screens/performance/panes/timeline_events/timeline_events_view.dart b/.../devtools_app/lib/src/screens/performance/panes/timeline_events/timeline_events_view.dart
@@ -49,7 +49,8 @@ class _TimelineEventsTabViewState extends State<TimelineEventsTabView>
     super.initState();
     addAutoDisposeListener(widget.controller.status, () {
       final status = widget.controller.status.value;
-      if (status == EventsControllerStatus.refreshing) {
+      if (status == EventsControllerStatus.refreshing &&
+          widget.controller.isActiveFeature) {
         _insertOverlay();
       } else {
         _removeOverlay();

diff --git a/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md b/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
@@ -19,7 +19,8 @@ TODO: Remove this section if there are not any general updates.
 
 ## Performance updates
 
-TODO: Remove this section if there are not any general updates.
+* Fixed an issue with the "Refreshing timeline" overlay that was getting shown
+when it should not have been. - [#8318](https://github.com/flutter/devtools/pull/8318)
 
 ## CPU profiler updates