Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance screen: implement rebuild indicators #4564

Open
1 of 2 tasks
jacob314 opened this issue Sep 30, 2022 · 0 comments
Open
1 of 2 tasks

Performance screen: implement rebuild indicators #4564

jacob314 opened this issue Sep 30, 2022 · 0 comments
Labels
P1 high priority issues at the top of the work list, actively being worked on. screen: performance Issues with the Performance screen

Comments

@jacob314
Copy link
Contributor

jacob314 commented Sep 30, 2022 •
edited by kenzieschmoll
Loading

@jacob314 jacob314 added screen: performance Issues with the Performance screen P3 labels Sep 30, 2022
@kenzieschmoll kenzieschmoll added P1 high priority issues at the top of the work list, actively being worked on. and removed P3 labels Jul 5, 2023
@kenzieschmoll kenzieschmoll mentioned this issue Apr 22, 2024
Closed
@helin24 helin24 mentioned this issue May 20, 2024
Merged
9 tasks
auto-submit bot pushed a commit to flutter/flutter that referenced this issue May 22, 2024
@helin24
Add frame number and widget location map service extension (#148702)
edf312d 
This helps us add widget rebuild counts to the DevTools performance page: flutter/devtools#4564
This was referenced May 23, 2024
Merged
Merged
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 29, 2024
@helin24
Add type Event ot postEvent
7098884 
IntelliJ expects a "type" field for events; otherwise the JSON will not be parsed correctly. This came up as part of making the widget rebuild table in DevTools clickable (flutter/devtools#4564)

I'm not totally sure this is the change I need, as I don't know how to test this out end-to-end (build Dart SDK and put into Flutter SDK, then run an app with these changes in DDS?). I think it's right because I'm modifying a spot that was first added in https://dart-review.googlesource.com/c/sdk/+/304981, which added `postEvent` in dds_service_extension.

Change-Id: I9a78903dca7855896b6a9b9c3f9e1d62dcb7099e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368202
Reviewed-by: Dan Chevalier <danchevalier@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this issue May 30, 2024
@helin24
Add frame number and widget location map service extension (flutter#1…
be60723 
…48702)

This helps us add widget rebuild counts to the DevTools performance page: flutter/devtools#4564
victorsanni pushed a commit to victorsanni/flutter that referenced this issue May 31, 2024
@helin24 @victorsanni
Add frame number and widget location map service extension (flutter#1…
1d42e39 
…48702)

This helps us add widget rebuild counts to the DevTools performance page: flutter/devtools#4564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 high priority issues at the top of the work list, actively being worked on. screen: performance Issues with the Performance screen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacob314 @kenzieschmoll