Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DTDConnectionInfo and replace with a class that can handle separate private/exposed URIs #8291

Merged
merged 7 commits into from
Sep 9, 2024

Commits on Sep 3, 2024

  1. Deprecate DTDConnectionInfo and replace with a class that can handle …

    …separate private/exposed URIs
    
    This replaces `DTDConnectionInfo` with `DTDInfo` (unsure if a better name?) and marks the former as deprecated.
    
    The new class has two URIs:
    
    - `localUri` which is the URI used for backend services on the same machine as the DTD process (this is usually a `localhost` URI)
    - `exposedUri` which is the URI that can be used from the frontend where the user is (this may or may not be the same as localUri depending on whether they're in a remote/web IDE session)
    
    The DevTools web API returns the exposed URI (since it will be used by frontend tools) and other places that used the URI for connecting directly use the local one.
    
    On its own, this change doesn't do anything, the intention is to roll this into the SDK and update the DevTools server code in dartdev/DDS to accept an additional optional URI which will then provide these back to the server code here (for the web API handler and extension search code).
    
    This is work towards fixing some of the issues in Dart-Code/Dart-Code#5158.
    DanTup committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e9a54a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Rename DTDInfo -> DtdInfo

    DanTup committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    40d908a View commit details
    Browse the repository at this point in the history
  2. Tweak comments + remove TODO

    DanTup committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b041927 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Fix casing

    DanTup committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a33782f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    d4eaf26 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    3ad0e27 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd4407d View commit details
    Browse the repository at this point in the history