Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for the optional parameters that will be added in package:vm_service 14.3.0 #8300

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Account for the optional parameters that will be added in package:vm_service 14.3.0 #8300

merged 1 commit into from
Sep 9, 2024

Conversation

derekxu16
Copy link
Contributor

This is needed to land the SDK CL that checks in package:vm_service 14.3.0, because this is needed to make the g3-cbuild-try job pass.

@derekxu16
Account for the optional parameters that will be added in package:vm_…
3bf9c4d 
…service 14.3.0

This is needed to land the SDK CL that checks in package:vm_service 14.3.0, because this is needed to make the g3-cbuild-try job pass.
@derekxu16 derekxu16 force-pushed the account-for-new-optional-parameters-of-vm-service branch from 99fcc1c to 3bf9c4d Compare September 9, 2024 13:20
@derekxu16 derekxu16 marked this pull request as ready for review September 9, 2024 13:44
@derekxu16 derekxu16 requested a review from a team as a code owner September 9, 2024 13:44
@derekxu16 derekxu16 requested review from kenzieschmoll and removed request for a team September 9, 2024 13:44
kenzieschmoll
kenzieschmoll reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to bump the vm_service version in the DevTools pubspec?

@derekxu16
Copy link
Contributor Author

derekxu16 commented Sep 9, 2024 •
edited
Loading

do we need to bump the vm_service version in the DevTools pubspec?

Not until calls to getObject that include an idZoneId argument are added to DevTools. I'm only making this change now because g3-cbuild-try tests against the DevTools code in g3, so I can't land my SDK changes until I stop the job from failing with the error "The method 'FakeVmServiceWrapper.getObject’ has fewer named arguments than those of overridden method 'VmService.getObject'."

@derekxu16 derekxu16 merged commit 36ad9ab into flutter:master Sep 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekxu16 @kenzieschmoll