[deep link] Add sub checks for ios domain error - format error #8309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangyujin
requested review from
bkonyi and
kenzieschmoll
and removed request for
a team and
bkonyi
| final List<AASAfileFormatSubCheck> subcheckErrors; | ||
| } | ||
|
|
||
| IosDomainError iosFileFormatDomainError({ |
There was a problem hiding this comment.
can this be a static method on IosDomainError for consistency with how the other errors are defined?
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_services.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart
Outdated
Show resolved
Hide resolved
|
|
||
| static const appLinksFormat = AASAfileFormatSubCheck( | ||
| 'Applinks format', | ||
| 'This test checks if the `applinks` property holds an object.', |
There was a problem hiding this comment.
nit: in all the error explanations above, we use the verbiage "checks that" instead of "checks if". Let's use "checks that" where applicable in these errors for consistency
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart
Outdated
Show resolved
Hide resolved
Comment on lines
235
to
238
| 'This test checks for `applinks.details.default`. Ref - ' | ||
| 'https://developer.apple.com/documentation/bundleresources/applinks/details/default' | ||
| 'This checks if the `Defaults` property only holds `caseSensitive` and' | ||
| '`percentEncoded`.', |
There was a problem hiding this comment.
same comment as above for the applinks.defaults property
|
|
||
| static const componentPathFormat = AASAfileFormatSubCheck( | ||
| 'Applinks details components path format', | ||
| 'This test checks if the `applinks.details.components.path` property only holds a string.', |
There was a problem hiding this comment.
nit: we should be consistent with whether we capitalize "s" in the word string throughout these errors
packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart
Outdated
Show resolved
Hide resolved
hangyujin
force-pushed
the
subchecks
branch
from
edc85e5
to
d598708
Compare
resolve comments lint lint add tests Update deep_links_services.dart Update deep_links_services.dart UI Update deep_links_model.dart add subchecks Update deep_links_model.dart 1
hangyujin
force-pushed
the
subchecks
branch
from
d598708
to
69524b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR.
Please add a note to
packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.mdif your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.Pre-launch Checklist
///).If you need help, consider asking for help on Discord.