Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm APIs to GA #36

Merged
merged 3 commits into from
May 13, 2024
Merged

Update Helm APIs to GA #36

merged 3 commits into from
May 13, 2024

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented May 7, 2024

Changes:

  • Update HelmRelease API to v2
  • Update HelmRepository and HelmChart APIs to v1
  • Use OCIRepository for kube-prometheus-stack
  • Add chart_app_version and chart_ref_name labels to gotk_resource_info{customresource_kind="HelmRelease"}

Depends on: fluxcd/helm-controller#968
Part of: fluxcd/flux2#4712

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some manual testing and it looks good to me.

Highlighted the two new fields and revision for OCIRepository chart ref below:

gotk_resource_info{chart_app_version="v0.73.2", chart_name="kube-prometheus-stack", chart_ref_name="kube-prometheus-stack", container="kube-state-metrics", customresource_group="helm.toolkit.fluxcd.io", customresource_kind="HelmRelease", customresource_version="v2", endpoint="http", exported_namespace="monitoring", instance="10.244.0.40:8080", job="kube-state-metrics", name="kube-prometheus-stack", namespace="monitoring", pod="kube-prometheus-stack-kube-state-metrics-6cdcf846c8-6vxg2", ready="True", revision="58.5.1+18700a3db973", service="kube-prometheus-stack-kube-state-metrics"}

@stefanprodan stefanprodan merged commit a80c727 into main May 13, 2024
4 checks passed
@stefanprodan stefanprodan deleted the helmrelease-v2 branch May 13, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants