Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container registry and image pull secret as install options #128

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jul 23, 2020

Changes to install and bootstrap commands:

  • Add container registry optional arg
  • Add image pull secret optional arg

Example of installing the toolkit using images from a private repository:

tk install \
--namespace=gitops-system \
--components=source-controller,kustomize-controller \
--registry=registry.internal/fluxcd \
--image-pull-secret=regcred

kubectl -n gitops-system create secret generic regcred \
    --from-file=.dockerconfigjson=/.docker/config.json \
    --type=kubernetes.io/dockerconfigjson

@stefanprodan stefanprodan added enhancement New feature or request area/UX area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests labels Jul 23, 2020
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason the registry is configurable but the image name and tag aren't?

@stefanprodan
Copy link
Member Author

stefanprodan commented Jul 23, 2020

@hiddeco I don't want to allow people to change the image names or tags, they should pull our official images and push them to their repos maintaining our version, otherwise it will not be possible to track bugs to a version. It also fits with corporate image mirrors where the name:tag is preserved.

@nab-gha
Copy link

nab-gha commented Jul 23, 2020

LGTM

@stefanprodan stefanprodan merged commit 13dba62 into master Jul 23, 2020
@stefanprodan stefanprodan deleted the container-registry branch July 23, 2020 12:34
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants