Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tk binary to gotk #180

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Rename tk binary to gotk #180

merged 1 commit into from
Sep 1, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Aug 25, 2020

To avoid conflicts with the tk binary from the Tanka project.

Fixes #174

@hiddeco hiddeco force-pushed the rename-tk-to-gotk branch 2 times, most recently from c55616e to 684892a Compare August 25, 2020 19:21
To avoid conflicts with the `tk` binary from the Tanka project.
@hiddeco hiddeco marked this pull request as ready for review September 1, 2020 09:34
@squaremo
Copy link
Member

squaremo commented Sep 1, 2020

I know I said I preferred this name, but Leigh mentioned that it looks like go(lang) tooling and now I can't unsee it ...
(I can probably get over this)

@hiddeco
Copy link
Member Author

hiddeco commented Sep 1, 2020

I can see why, @stefanprodan mentioned that he isn't a big fan of how it would be pronounced (although it reads nice). I am however very short on other options that make sense for a CLI tool that drives the "GitOps Toolkit".

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I'm happy with this change but we should play nice and avoid conflicting with Tanka

@hiddeco hiddeco merged commit 75364dd into master Sep 1, 2020
@hiddeco hiddeco deleted the rename-tk-to-gotk branch September 1, 2020 10:33
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tk binary conflicts with Tanka
3 participants