Support GitRepository sources in HelmReleases #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
area/source
hiddeco
force-pushed
the
update-tk-components
branch
2 times, most recently
from
9e668e7
to
ef4713c
Compare
hiddeco
force-pushed
the
update-tk-components
branch
4 times, most recently
from
3ea6533
to
9c104ee
Compare
* github.com/fluxcd/helm-controller/api to v0.0.6 * github.com/fluxcd/source-controller/api to v0.0.13 * k8s.io/api to v0.18.8 * k8s.io/apiextensions-apiserver to v0.18.8 * k8s.io/apimachinery to v0.18.8 * k8s.io/client-go to v0.18.8 * sigs.k8s.io/controller-runtime to v0.6.2
hiddeco
force-pushed
the
update-tk-components
branch
from
9c104ee
to
e53d0da
Compare
hiddeco
changed the title
stefanprodan
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Toolkit components (helm-controller and source-controller) to the versions that include support for
GitRepositorysources inHelmChartandHelmReleaseresources.It also introduces some minor (but breaking) changes to the
gotk create hrcommand, to take thekindof the--sourceinto account, and includes a rename from--chart-nameto--chartto match the name of the field in the spec of theHelmReleaseagain.List of upgrades: