diff: additional test cases

Signed-off-by: Hidde Beydals <hello@hidde.co>
fluxcd · Feb 22, 2023 · ee4b8a6 · ee4b8a6
1 parent 93ee87f
commit ee4b8a6
Showing 1 changed file with 113 additions and 0 deletions.
diff --git a/internal/diff/differ_test.go b/internal/diff/differ_test.go
@@ -18,6 +18,7 @@ package diff
 
 import (
 	"context"
+	"fmt"
 	"testing"
 
 	. "github.com/onsi/gomega"
@@ -87,6 +88,14 @@ metadata:
   name: test
 stringData:
   foo: bar
+---
+apiVersion: v1
+kind: Secret
+metadata:
+  name: test-ns
+  namespace: other
+stringData:
+  foo: bar
 `,
 			},
 			want: &ssa.ChangeSet{
@@ -103,10 +112,114 @@ stringData:
 						Subject:      "Secret/release/test",
 						Action:       ssa.CreatedAction,
 					},
+					{
+						ObjMetadata: object.ObjMetadata{
+							Namespace: "other",
+							Name:      "test-ns",
+							GroupKind: schema.GroupKind{
+								Kind: "Secret",
+							},
+						},
+						GroupVersion: "v1",
+						Subject:      "Secret/other/test-ns",
+						Action:       ssa.CreatedAction,
+					},
+				},
+			},
+			wantDrift: true,
+		},
+		{
+			name: "ignores exclusions",
+			client: fake.NewClientBuilder().
+				WithScheme(scheme).
+				WithRESTMapper(mapper).
+				Build(),
+			rel: &release.Release{
+				Namespace: "release",
+				Manifest: fmt.Sprintf(`---
+apiVersion: v1
+kind: Secret
+metadata:
+  name: test
+  labels:
+    %[1]s: %[2]s
+stringData:
+    foo: bar
+---
+apiVersion: v1
+kind: Secret
+metadata:
+  name: test2
+stringData:
+  foo: bar
+`, MetadataKey, MetadataDisabledValue),
+			},
+			want: &ssa.ChangeSet{
+				Entries: []ssa.ChangeSetEntry{
+					{
+						ObjMetadata: object.ObjMetadata{
+							Namespace: "release",
+							Name:      "test",
+							GroupKind: schema.GroupKind{
+								Kind: "Secret",
+							},
+						},
+						GroupVersion: "v1",
+						Subject:      "Secret/release/test",
+						Action:       ssa.SkippedAction,
+					},
+					{
+						ObjMetadata: object.ObjMetadata{
+							Namespace: "release",
+							Name:      "test2",
+							GroupKind: schema.GroupKind{
+								Kind: "Secret",
+							},
+						},
+						GroupVersion: "v1",
+						Subject:      "Secret/release/test2",
+						Action:       ssa.CreatedAction,
+					},
 				},
 			},
 			wantDrift: true,
 		},
+		{
+			name: "ignores exclusions (without diff)",
+			client: fake.NewClientBuilder().
+				WithScheme(scheme).
+				WithRESTMapper(mapper).
+				Build(),
+			rel: &release.Release{
+				Namespace: "release",
+				Manifest: fmt.Sprintf(`---
+apiVersion: v1
+kind: Secret
+metadata:
+  name: test
+  labels:
+    %[1]s: %[2]s
+stringData:
+    foo: bar`, MetadataKey, MetadataDisabledValue),
+			},
+			want: &ssa.ChangeSet{
+				Entries: []ssa.ChangeSetEntry{
+					{
+						ObjMetadata: object.ObjMetadata{
+							Namespace: "release",
+							Name:      "test",
+							GroupKind: schema.GroupKind{
+								Kind: "Secret",
+							},
+						},
+						GroupVersion: "v1",
+						Subject:      "Secret/release/test",
+						Action:       ssa.SkippedAction,
+					},
+				},
+			},
+			wantDrift: false,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {