Capture and expose debug (log) information on release failure #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
area/helm
|
@hiddeco may I suggest we buffer the log lines after eliminating duplicates? This way an ingress/lb/volume being stuck will not pollute the event. |
|
I would prioritize this to trim down the support burden, users can’t figure out why releases are failing when wait times out. |
hiddeco
force-pushed
the
debug-wait-logs
branch
5 times, most recently
from
774c0cf
to
12322e3
Compare
hiddeco
commented
Mar 24, 2021
| @@ -328,14 +328,14 @@ func (r *HelmReleaseReconciler) reconcileRelease(ctx context.Context, | |||
| // Fail if install retries are exhausted. | |||
| if hr.Spec.GetInstall().GetRemediation().RetriesExhausted(hr) { | |||
| err = fmt.Errorf("install retries exhausted") | |||
| return v2.HelmReleaseNotReady(hr, released.Reason, released.Message), err | |||
| return v2.HelmReleaseNotReady(hr, released.Reason, err.Error()), err | |||
There was a problem hiding this comment.
This (and the change below) are required because otherwise the long error message will still end up in the Ready condition.
It will also make the error more visible to users, as I know from providing support to people that it is a bit hidden at the moment.
hiddeco
force-pushed
the
debug-wait-logs
branch
from
12322e3
to
adb083b
Compare
This provides richer debugging information for wait timeouts, e.g. ``` wait.go:225: [debug] Service does not have load balancer ingress IP address: deis/deis-builder wait.go:225: [debug] Service does not have load balancer ingress IP address: deis/deis-builder ``` Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
debug-wait-logs
branch
from
adb083b
to
314472e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nlast log lines for the actionFixes #218.