Set leader election deadline to 30s #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
leader-election-config
branch
from
a2cc1be
to
efc44cb
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
leader-election-config
branch
from
efc44cb
to
b74081d
Compare
stefanprodan
changed the title
hiddeco
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Tested various disruptions on a Kubernetes v1.20.4 "production" cluster without any issues. Thanks @stefanprodan 💯
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
reviewed
Mar 25, 2021
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows fine tuning the leader election with cmd args:
To make the leader election more tolerant to transient Kubernetes API outages, the renewal deadline was increased from 10s to 30s and the retry interval was bumped to 5 seconds.
Test image:
Part of: fluxcd/pkg#94