Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support defining a KubeConfig Secret data key #461

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

nstogner
Copy link
Contributor

Fixes #458.

@nstogner
Copy link
Contributor Author

I didn't see a test suite where I could add coverage for this new field. Let me know if I missed something.

@nstogner
Copy link
Contributor Author

nstogner commented Apr 23, 2022

Can I get a review on this PR?

PS: make test is failing. Not sure why at the moment:

make test
cd api; rm -f go.sum; go mod tidy -compat=1.17
rm -f go.sum; go mod tidy -compat=1.17
cd api; /Users/nick/go/bin/controller-gen object:headerFile="../hack/boilerplate.go.txt" paths="./..."
go fmt ./...
cd api; go fmt ./...
go vet ./...
cd api; go vet ./...
/Users/nick/go/bin/controller-gen crd:crdVersions=v1 rbac:roleName=manager-role paths="./..." output:crd:artifacts:config="config/crd/bases"
cd api; /Users/nick/go/bin/controller-gen crd:crdVersions=v1 rbac:roleName=manager-role paths="./..." output:crd:artifacts:config="../config/crd/bases"
/Users/nick/go/bin/gen-crd-api-reference-docs -api-dir=./api/v2beta1 -config=./hack/api-docs/config.json -template-dir=./hack/api-docs/template -out-file=./docs/api/helmrelease.md
I0423 16:20:54.985522   43765 main.go:129] parsing go packages in directory ./api/v2beta1
I0423 16:20:55.089645   43765 main.go:231] using package=./api/v2beta1
F0423 16:20:55.097017   43765 main.go:503] type invalid type has kind=Unsupported which is unhandled
make: *** [api-docs] Error 255

@nstogner nstogner force-pushed the secret-ref-key branch 2 times, most recently from 522e240 to db75546 Compare April 27, 2022 13:11
Signed-off-by: Nick Stogner <nicholas.stogner@gmail.com>
@hiddeco hiddeco added the enhancement New feature or request label Apr 28, 2022
@hiddeco hiddeco changed the title Add .spec.kubeConfig.secretRef.key Support defining a KubeConfig Secret data key Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specifying a Secret key containing a kubeconfig
2 participants