Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart metadata by making it truly optional #665

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Apr 3, 2023

Make the .spec.chart.spec.metadata optional by setting its value to a pointer of HelmChartTemplateObjectMeta .

@stefanprodan stefanprodan added bug Something isn't working area/helm Helm related issues and pull requests labels Apr 3, 2023
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darkowlzz darkowlzz merged commit 527ab97 into main Apr 3, 2023
@darkowlzz darkowlzz deleted the fix-chart-meta branch April 3, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants