Enable GPG Signing of Commits #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LWJ <lwjames1996@gmail.com>
Signed-off-by: LWJ <lwjames1996@gmail.com>
Signed-off-by: LWJ <lwjames1996@gmail.com>
squaremo
requested changes
Mar 29, 2021
|
Thanks @squaremo for reviewing! I'll get these changes made this evening 😄 |
Signed-off-by: LWJ <lwjames1996@gmail.com>
squaremo
reviewed
Mar 30, 2021
Signed-off-by: LWJ <lwjames1996@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #122
Added a new (optional) SigningKey field to the CommitSpec with a secretRef. This secret can be generated the exact same way as described in the SOPS guide, so it should be easy for existing users to understand - the only difference is the key is named
git.ascrather thansops.asc.Once any modifications have been suggested/made, I could make a pull request to the flux2 project with some documentation and CLI changes.