Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg/runtime consts for log levels #232

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Use pkg/runtime consts for log levels #232

merged 1 commit into from
Oct 6, 2021

Conversation

squaremo
Copy link
Member

@squaremo squaremo commented Oct 6, 2021

github.com/fluxcd/pkg/runtime/logger now supports the trace log level, and has consts for the V(...) argument to supply. This commit updates that module so to use those consts.

Previously, trace messages were output at the debug level; after this commit they will be in their own level, so you need

--log-level=trace

to see them.

github.com/fluxcd/pkg/runtime/logger now supports the trace log level,
and has consts for the V(...) argument to supply. This commit updates
that module so to use those consts.

Previously, trace messages were output at the debug level; after this
commit they will be in their own level, so you need

    --log-level=trace

to see them.

Signed-off-by: Michael Bridgen <michael@weave.works>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @squaremo

@squaremo squaremo merged commit 263ff7c into main Oct 6, 2021
@squaremo squaremo deleted the use-trace-loglevel branch October 6, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants