add support for specified proxy in source GitRepository #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan9600
force-pushed
the
proxy-options
branch
from
e7add95
to
d0d1f7d
Compare
makkes
reviewed
Aug 2, 2023
This was referenced Aug 2, 2023
aryan9600
force-pushed
the
proxy-options
branch
from
d0d1f7d
to
6416efd
Compare
|
@makkes the tests for proxy exist in |
aryan9600
force-pushed
the
proxy-options
branch
from
6416efd
to
3766025
Compare
|
@aryan9600 but that doesn't test the wiring of Secret data to actually performing the operation, which should have coverage here. |
aryan9600
force-pushed
the
proxy-options
branch
from
3766025
to
cb1a92f
Compare
That's great but this change adds a lot of code around the functionality from pkg/git/gogit that we should test. |
aryan9600
force-pushed
the
proxy-options
branch
from
213a0d0
to
96d3827
Compare
makkes
approved these changes
Aug 4, 2023
aryan9600
force-pushed
the
proxy-options
branch
from
96d3827
to
d32d13a
Compare
makkes
previously requested changes
Aug 4, 2023
aryan9600
force-pushed
the
proxy-options
branch
from
d32d13a
to
6d91fb7
Compare
Add proxy support for Git operations using the proxy configuration specified in the source GitRepository's `.spec.proxySecretRef`. Refactor the Git client building process to make it more testable. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Retry reconciliation in `TestImageUpdateAutomationReconciler_deleteBeforeFinalizer` as sometimes it fails with a latest version conflict error. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
proxy-options
branch
from
6d91fb7
to
95a7b39
Compare
stefanprodan
approved these changes
Aug 23, 2023
aryan9600
added
enhancement
hiddeco
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using the proxy specified in the source GitRepository using its
.spec.proxySecretRef.also closes #575